Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID casing fixes #18467

Merged
merged 2 commits into from
Sep 22, 2022
Merged

ID casing fixes #18467

merged 2 commits into from
Sep 22, 2022

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Sep 20, 2022 •
edited by katbyte
Loading

azurerm_monitor_diagnostic_settings: fix casing parsing for workspace_id
azurerm_security_center_workspace: fix casing parsing for workspace_id

Fixes #18346
Fixes #18360

@favoretti favoretti force-pushed the favoretti/diag_setting_casing branch from 0ada834 to 3db9826 Compare September 20, 2022 16:44
@favoretti favoretti changed the title azurerm_monitor_diagnostic_settings: fix casing parsing ID casing fixes Sep 20, 2022
@favoretti
Copy link
Collaborator Author

image

@favoretti
Copy link
Collaborator Author

image
Failures are old and not related to the change.

@favoretti
ID casing fixes
eb1c537 
`azurerm_monitor_diagnostic_settings`: fix casing parsing
`azurerm_user_assigned_identity`: fix casing parsing
`azurerm_security_center_workspace`: fix casing parsing

Fixes hashicorp#18346
Fixes hashicorp#14853
Fixes hashicorp#18360
@favoretti favoretti force-pushed the favoretti/diag_setting_casing branch from 3db9826 to eb1c537 Compare September 21, 2022 12:42
katbyte
katbyte requested changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @favoretti - 2 of the 3 LGTM and i just think we need to do a state migration for the 3 i've left a comment on

internal/services/msi/user_assigned_identity_resource.go Outdated Show resolved Hide resolved
@favoretti
Copy link
Collaborator Author

@katbyte API returns is consistently incorrectly and it's all fixes for Read, no matter how we store it in state, response from the API will be wrong.

Not sure state migration would help any in this case?

katbyte
katbyte approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌩️

@katbyte katbyte merged commit 375102a into hashicorp:main Sep 22, 2022
@github-actions github-actions bot added this to the v3.24.0 milestone Sep 22, 2022
katbyte added a commit that referenced this pull request Sep 22, 2022
@katbyte
CHANGELOG #18467
107a7ef
@teowa teowa mentioned this pull request Sep 23, 2022
Closed
@github-actions
Copy link

This functionality has been released in v3.24.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@achupryn achupryn mentioned this pull request Oct 11, 2022
Open
1 task
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
service/monitor service/security-center waiting-response
Projects
None yet
Milestone
v3.24.0
2 participants
@favoretti @katbyte